Re: [PATCH 5/5] Documentation: Add documentation for rt5033 multifunction device

From: Mark Brown
Date: Fri Nov 07 2014 - 05:36:24 EST


On Fri, Nov 07, 2014 at 11:52:07AM +0900, Beomho Seo wrote:

> +Required properties:
> +- compatible = Must be "richtek,rt5033-regulator"
> +
> + regulators {
> + compatible = "richtek,rt5033-regulator";

There should be no need for this extra compatible, it's not adding
anything we didn't know from the fact that it's part of the MFD.

> + regulator-name {
> + regulator-name = LDO/BUCK
> + standard regulator constraints...
> + };

Better to just say something like "regulator subnodes called X, Y and Z"
described using the standard regulator binding in...

Attachment: signature.asc
Description: Digital signature