Re: [PATCH] clocksource: tegra: Port tegra20 clocksource to arm64

From: Stephen Warren
Date: Thu Nov 06 2014 - 23:17:14 EST


On 11/06/2014 05:21 PM, Anatol Pomozov wrote:
> register_persistent_clock() are in different headers in arm/arm64
>
> Tested: Compiled the driver on 64bit platform and make sure that
> it works

I assume "it works" refers to "it compiles" not "it executes successfully"?

I think it'd be better to make the same APIs available on arm and arm64,
or even across all architectures.

> Signed-off-by: Anatol Pomozov <anatol.pomozov@xxxxxxxxx>
> ---
> drivers/clocksource/tegra20_timer.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/clocksource/tegra20_timer.c b/drivers/clocksource/tegra20_timer.c
> index d2616ef..e0123c7 100644
> --- a/drivers/clocksource/tegra20_timer.c
> +++ b/drivers/clocksource/tegra20_timer.c
> @@ -29,8 +29,12 @@
> #include <linux/sched_clock.h>
> #include <linux/delay.h>
>
> +#ifdef CONFIG_ARM64
> +#include <asm/time.h>
> +#else
> #include <asm/mach/time.h>
> #include <asm/smp_twd.h>
> +#endif
>
> #define RTC_SECONDS 0x08
> #define RTC_SHADOW_SECONDS 0x0c
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/