Re: [PATCH 1/2] mm: export find_extend_vma and handle_mm_fault for driver use

[Oded Gabbay]

On 11/05/2014 11:51 PM, Jesse Barnes wrote:
> On Wed, 5 Nov 2014 13:03:51 +0100
> Joerg Roedel <jroedel@xxxxxxx> wrote:
>
> > Hi Oded, Jesse,
> >
> > On Wed, Oct 29, 2014 at 11:33:38AM +0200, Oded Gabbay wrote:
> > > I tested our amdkfd driver with your patches applied (kernel 3.17.1).
> > > I run OpenCL tests, Aparapi/Sumatra (Java) and OpenMP
> > >
> > > All tests passed and I didn't see any kernel error messages.
> > >
> > > So:
> > >
> > > Tested-by: Oded Gabbay <oded.gabbay@xxxxxxx>
> >
> > Thanks for testing Oded. Jesse, the patch looks good to me, except the
> > task accounting for the page-faults. I'd like to get rid of using
> > task_struct in the IOMMUv2 driver entirely if possible. Also it is not
> > really the CPU task causing the faults, but some non-CPU process.
>
> Hm, but the CPU task initiates the activity on the GPU, so we should
> account for it somewhere, right?  I guess I had been thinking of the
> "task" as spanning the CPUs and GPUs and other devices in the system,
> rather than just representing the CPU activity.

Joerg, sorry for the dumb question but what do you mean by "task accounting for 
page-faults"? Where is that code in IOMMUv2 driver now ?

> > So can you please remove that code and resend the patches with Oded's
> > Tested-by and Andrew Morton on Cc? I think these patches should go
> > through the -mm tree.
>
> Sure, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/