Re: [PATCH] phy: omap-usb2: Enable runtime PM of omap-usb2 phy properly

From: Greg KH
Date: Wed Nov 05 2014 - 17:30:05 EST


On Wed, Nov 05, 2014 at 06:54:23PM +0100, Sebastian Reichel wrote:
> Hi,
>
> On Tue, Nov 04, 2014 at 11:47:06AM +0530, Kishon Vijay Abraham I wrote:
> > From: Oussama Ghorbel <ghorbel@xxxxxxxxxxxxxxxx>
> >
> > The USB OTG port does not work since v3.16 on omap platform.
> > This is a regression introduced by the commit
> > eb82a3d846fa (phy: omap-usb2: Balance pm_runtime_enable() on probe failure
> > and remove).
> > This because the call to pm_runtime_enable() function is moved after the
> > call to devm_phy_create() function, which has side effect since later in
> > the subsequent calls of devm_phy_create() there is a check with
> > pm_runtime_enabled() to configure few things.
> >
> > Signed-off-by: Oussama Ghorbel <ghorbel@xxxxxxxxxxxxxxxx>
> > Tested-by: Rabin Vincent <rabin@xxxxxx>
> > Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
>
> stable annotations are missing. See
>
> Documentation/stable_kernel_rules.txt

I can take care of that, thanks.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/