Re: [PATCH 0/7] Pinctrl support for Zynq

From: Andreas Färber
Date: Wed Nov 05 2014 - 00:56:58 EST


Hi Sören,

Am 03.11.2014 um 20:05 schrieb Soren Brinkmann:
> Soren Brinkmann (7):
> pinctrl: pinconf-generic: Declare dt_params/conf_items const
> pinctrl: pinconf-generic: Infer map type from DT property
> pinctrl: pinconf-generic: Allow driver to specify DT params
> pinctrl: zynq: Document DT binding
> pinctrl: Add driver for Zynq
> ARM: zynq: Enable pinctrl
> ARM: zynq: DT: Add pinctrl information

Thanks for your work on this,

Tested-by: Andreas Färber <afaerber@xxxxxxx>

I've tracked down all 54 MIO pins of the Parallella and cooked up the
equivalent DT patch. QSPI and USB still seem to be missing drivers
upstream; I reused the SPI driver for the QSPI with pinctrl and
Punnaiah's chipidea driver (not fully working) without pinctrl for lack
of group/function definitions. For testing purposes I've configured a
heartbeat trigger for the USER_LED (CR10).

To my disappointment these pinctrl additions did not fix one issue:
Whenever a write access to be handled by the bitstream (0x808f0f04) is
performed, the board hangs and the heartbeat stops. Would a bug in the
bitstream allow this to happen, or are more drivers missing to actually
make use of the PL in general? With a downstream ADI/Xilinx 3.12 kernel
that problem does not surface.

Regards,
Andreas

https://github.com/afaerber/linux/commits/parallella-next

--
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg

Attachment: signature.asc
Description: OpenPGP digital signature