Re: [PATCH 2/4] chardev: Increment cdev reference count when i_cdev references it

From: Christoph Hellwig
Date: Tue Nov 04 2014 - 04:53:10 EST


On Wed, Oct 22, 2014 at 10:14:11PM +0200, Jan Kara wrote:
> Currently i_cdev reference to a character device isn't accounted in the
> reference count of the character device. This then requires us to track
> all references through a list of all inodes referencing a character
> device which is somewhat clumsy and requires list_head in each inode in
> the system.
>
> So make i_cdev a reference like any other.

Looks good.

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

Maybe you can rename the new variable to something like to_put also?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/