Re: [V9 PATCH 2/2] irqchip: gicv2m: Add supports for ARM GICv2m MSI(-X)

[Suravee Suthikulanit]

On 11/3/2014 3:50 AM, Marc Zyngier wrote:
> > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
> > >index a99c211..4069eb3 100644
> > >--- a/drivers/irqchip/irq-gic.c
> > >+++ b/drivers/irqchip/irq-gic.c
> > >@@ -46,6 +46,7 @@
> > >  #include <asm/smp_plat.h>
> > >
> > >  #include "irq-gic-common.h"
> > >+#include "irq-gic-v2m.h"
> > >  #include "irqchip.h"
> > >
> > >  union gic_base {
> > >@@ -68,6 +69,9 @@ struct gic_chip_data {
> > >  #ifdef CONFIG_GIC_NON_BANKED
> > >         void __iomem *(*get_base)(union gic_base *);
> > >  #endif
> > >+#ifdef CONFIG_ARM_GIC_V2M
> > >+       struct list_head v2m_list;
> > >+#endif
> Can't that be something private to the v2m widget driver? I don't think
> it brings anything to the main GIC driver.

Looking at this again, now that we use the hierarchy irqdomain, GIC no 
longer needs to be handling with children v2m. I'll remove this altogether.

Suravee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/