Re: [PATCH 7/7] mfd: ab8500: Decrement the power supply's device reference counter

From: Lee Jones
Date: Mon Nov 03 2014 - 13:01:16 EST


On Mon, 03 Nov 2014, Lee Jones wrote:

> On Tue, 14 Oct 2014, Krzysztof Kozlowski wrote:
>
> > Use power_supply_put() to decrement the power supply's device reference
> > counter.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> > ---
> > drivers/mfd/ab8500-sysctrl.c | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Applied, thanks.

Whoops, to hasty there -- unapplied.

What's going on with this set?

> > diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c
> > index 93b2d2c32ca3..d05a5719cfc4 100644
> > --- a/drivers/mfd/ab8500-sysctrl.c
> > +++ b/drivers/mfd/ab8500-sysctrl.c
> > @@ -51,6 +51,7 @@ static void ab8500_power_off(void)
> >
> > ret = power_supply_get_property(psy, POWER_SUPPLY_PROP_ONLINE,
> > &val);
> > + power_supply_put(psy);
> >
> > if (!ret && val.intval) {
> > charger_present = true;
> > @@ -73,6 +74,7 @@ static void ab8500_power_off(void)
> > pss[i]);
> > machine_restart("charging");
> > }
> > + power_supply_put(psy);
> > }
> >
> > shutdown:
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/