Re: [PATCH RFC v2 8/8] ARM: zynq: DT: Add pinctrl information

[Linus Walleij]

On Sun, Nov 2, 2014 at 9:20 PM, SÃren Brinkmann
<soren.brinkmann@xxxxxxxxxx> wrote:
(...)
>                 common {
>                         groups = "uart1_10_grp";
>                         function = "uart1";
>                         bias-pull-up = <0>;
>                         slew-rate = <0>;
>                         io-standard = <1>;
>                 };
>
>                 rx {
>                         pins = "MIO49";
>                         bias-high-impedance = <1>;
>                 };
>
>                 tx {
>                         pins = "MIO48";
>                         bias-high-impedance = <0>;
>                 };
(...)
>                 common {
>                         groups = "uart1_10_grp";
>                         function = "uart1";
>                 };
>
>                 rx {
>                         pins = "MIO49";
>                         slew-rate = <0>;
>                         io-standard = <1>;
>                         bias-high-impedance;
>                 };
>
>                 tx {
>                         pins = "MIO48";
>                         slew-rate = <0>;
>                         io-standard = <1>;
>                 };
>         };
>
> In a nutshell, yes, it's possible to work without the arguments for
> pull-up or tri-state. But it adds complexity in the driver and the DT
> description.

But isn't it obvious that the latter is easier for a human to read
and understand (and not misunderstand) and remember readability
of config is one of the design goals of DT...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/