Re: [PATCH v2] Add ltc3562 voltage regulator driver

From: Mark Brown
Date: Mon Nov 03 2014 - 07:10:50 EST


On Mon, Nov 03, 2014 at 09:10:08AM +0100, Mike Looijmans wrote:
> ïOn 10/30/2014 05:51 PM, Mark Brown wrote:

> >>+ np_child = of_get_child_by_name(np_regulators,
> >>+ ltc3562_regulators[i].name);
> >>+ if (np_child == NULL) {

> >Use the core support for looking up constraints please - set
> >regulators_node and so on.

> I've been reworking the driver, but this is the only feedback comment I
> didn't quite understand. What is it that I'm expected to do here? Probably
> just the name of the method I'm supposed to call here would be enough.

No function calls, just use regulators_node. What is unclear about the
functionality?

Attachment: signature.asc
Description: Digital signature