Re: [PATCH 2/2] regulator: of: Add support for parsing microvolts for suspend state

From: Chris Zhong
Date: Sun Nov 02 2014 - 19:28:15 EST



On 11/01/2014 04:49 PM, Javier Martinez Canillas wrote:
Hello Doug,

On 11/01/2014 04:52 AM, Doug Anderson wrote:
Leverage all the work that was done in (40e20d6 regulator: of: Add
support for parsing regulator_state for suspend state) and throw in
the ability to set suspend microvolts from the device tree.

Signed-off-by: Doug Anderson <dianders@xxxxxxxxxxxx>
---
drivers/regulator/of_regulator.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index f0d19fc..7fe93c5 100644
--- a/drivers/regulator/of_regulator.c
+++ b/drivers/regulator/of_regulator.c
@@ -107,6 +107,10 @@ static void of_get_regulation_constraints(struct device_node *np,
"regulator-off-in-suspend"))
suspend_state->disabled = true;
+ if (!of_property_read_u32(suspend_np,
+ "regulator-suspend-microvolt", &pval))
+ suspend_state->uV = pval;
+
of_node_put(suspend_np);
suspend_state = NULL;
suspend_np = NULL;

Looks good to me.

Reviewed-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>

Best regards,
Javier



Reviewed-by: Chris Zhong <zyw@xxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/