Re: [PATCH 1/2] mm: export find_extend_vma and handle_mm_fault for driver use

From: Jesse Barnes
Date: Wed Oct 29 2014 - 10:38:07 EST


Cool, thanks a lot, Oded. I guess my compiler did a good job making
sure there were no bugs. :)

Jesse

On Wed, 29 Oct 2014 11:33:38 +0200
Oded Gabbay <oded.gabbay@xxxxxxx> wrote:

> Hi Joerg and Jesse,
>
> I tested our amdkfd driver with your patches applied (kernel 3.17.1).
> I run OpenCL tests, Aparapi/Sumatra (Java) and OpenMP
>
> All tests passed and I didn't see any kernel error messages.
>
> So:
>
> Tested-by: Oded Gabbay <oded.gabbay@xxxxxxx>
>
> Oded
>
> On 10/27/2014 05:35 PM, Jesse Barnes wrote:
>
> Thanks, I have no way of testing this, but I'm hopeful. :)
>
> Jesse
>
> On Mon, 27 Oct 2014 17:15:45 +0200
> Oded Gabbay <oded.gabbay@xxxxxxx> wrote:
>
> > Sure, no problem
> >
> > Oded
> >
> > On 10/27/2014 05:13 PM, Joerg Roedel wrote:
> >
> > Hi Oded,
> >
> > can you please test these patches with the KFD driver and make sure
> > nothing breaks for you? I really like this improvement and it would be
> > great to send it upstream for v3.19.
> >
> > Thanks,
> >
> > Joerg
> >
> > On Fri, Oct 24, 2014 at 12:34:30PM -0700, Jesse Barnes wrote:
> >
> >> This lets drivers like the AMD IOMMUv2 driver handle faults a bit more
> >> simply, rather than doing tricks with page refs and get_user_pages().
> >>
> >> Signed-off-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> >> ---
> >> mm/memory.c | 1 +
> >> mm/mmap.c | 2 ++
> >> 2 files changed, 3 insertions(+)
> >>
> >> diff --git a/mm/memory.c b/mm/memory.c
> >> index 1cc6bfb..969ff0c 100644
> >> --- a/mm/memory.c
> >> +++ b/mm/memory.c
> >> @@ -3378,6 +3378,7 @@ int handle_mm_fault(struct mm_struct *mm, struct vm_area_struct *vma,
> >>
> >> return ret;
> >> }
> >> +EXPORT_SYMBOL_GPL(handle_mm_fault);
> >>
> >> #ifndef __PAGETABLE_PUD_FOLDED
> >> /*
> >> diff --git a/mm/mmap.c b/mm/mmap.c
> >> index 7f85520..2ee7971 100644
> >> --- a/mm/mmap.c
> >> +++ b/mm/mmap.c
> >> @@ -2359,6 +2359,8 @@ find_extend_vma(struct mm_struct *mm, unsigned long addr)
> >> }
> >> #endif
> >>
> >> +EXPORT_SYMBOL_GPL(find_extend_vma);
> >> +
> >> /*
> >> * Ok - we have the memory areas we should free on the vma list,
> >> * so release them, and do the vma updates.
> >> --
> >> 1.9.1
>
>
>


--
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/