Re: [PATCH][STABLE] audit: correct AUDIT_GET_FEATURE return message type

From: Paul Moore
Date: Wed Oct 29 2014 - 09:52:49 EST


On Wednesday, October 29, 2014 09:35:06 AM Richard Guy Briggs wrote:
> When an AUDIT_GET_FEATURE message is sent from userspace to the kernel, it
> should reply with a message tagged as an AUDIT_GET_FEATURE type with a
> struct audit_feature. The current reply is a message tagged as an
> AUDIT_GET type with a struct audit_feature.
>
> This appears to have been a cut-and-paste-eo in commit b0fed40.
>
> Reported-by: Steve Grubb <sgrubb@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # v3.13-rc1
> Signed-off-by: Richard Guy Briggs <rgb@xxxxxxxxxx>
> ---
> kernel/audit.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Acked-by: Paul Moore <paul@xxxxxxxxxxxxxx>

> diff --git a/kernel/audit.c b/kernel/audit.c
> index d20f00f..3a80abb 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -724,7 +724,7 @@ static int audit_get_feature(struct sk_buff *skb)
>
> seq = nlmsg_hdr(skb)->nlmsg_seq;
>
> - audit_send_reply(skb, seq, AUDIT_GET, 0, 0, &af, sizeof(af));
> + audit_send_reply(skb, seq, AUDIT_GET_FEATURE, 0, 0, &af, sizeof(af));
>
> return 0;
> }

--
paul moore
www.paul-moore.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/