Re: [RFC 2/2] staging: ion: debugfs to shrink pool

From: Dan Carpenter
Date: Mon Oct 27 2014 - 07:43:04 EST


On Thu, Oct 23, 2014 at 09:52:20PM +0900, Gioh Kim wrote:
> This patch creates debugfs files, /sys/kernel/debug/ion/heaps/system_shrink,
> to shrink pool or get pool size.
> Reading the file returns pool size and writing occurs to shrink pool.

The patch looks fine. Of course, the original code was debugfs before
it bitrotted and stopped compiling, but is there there a reason why we
shouldn't move this to sysfs instead? Just curious.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/