Re: [PATCH] drivers/rtc/interface.c: check the validation of rtc_time in __rtc_read_time

From: Andrew Morton
Date: Tue Oct 14 2014 - 18:21:36 EST


On Wed, 8 Oct 2014 11:05:29 +0900 Hyogi Gim <ciogenis@xxxxxxxxx> wrote:

> Some of rtc devices always return '0' when rtc_class_ops.read_time is called.
> So if rtc_time isn't verified in callback, rtc interface cannot know whether
> rtc_time is valid.

We should fix the buggy .read_time() implementations...

> Check rtc_time by using 'rtc_valid_tm' in '__rtc_read_time'. And add the
> message for debugging.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/