Re: [PATCH] um: always use the same type for __syscall_stub_start

From: Richard Weinberger
Date: Sat Oct 11 2014 - 07:42:33 EST


Am 11.10.2014 um 13:29 schrieb Nicolas Iooss:
> syscall_stub_start is declared with different types in C files:
>
> arch/um/kernel/physmem.c: extern int __syscall_stub_start;
> arch/um/kernel/skas/mmu.c: extern int __syscall_stub_start;
> arch/um/os-Linux/skas/mem.c: extern unsigned long __syscall_stub_start;
> arch/um/os-Linux/skas/process.c: extern int __syscall_stub_start;
>
> Fix this inconsistency by always using unsigned long. This does not
> change anything in the compiled code because only the address of
> __syscall_stub_start is used, but it makes the static checker I use
> stop complaining about incompatible declarations.

While we're here, can you put these declarations into a single header file?

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/