Re: [PATCH v3 1/2] power: reset: add LTC2952 poweroff support

[Frans Klaver]

On Tue, Oct 07, 2014 at 10:15:44AM +0200, Frans Klaver wrote:
> On Mon, Oct 06, 2014 at 02:32:10PM -0700, Guenter Roeck wrote:
> > On Mon, Oct 06, 2014 at 10:40:35AM +0200, Frans Klaver wrote:
> > > +static struct platform_driver ltc2952_poweroff_driver = {
> > > +	.probe = ltc2952_poweroff_probe,
> > > +	.remove = ltc2952_poweroff_remove,
> > > +	.driver = {
> > > +		.name = "ltc2952-poweroff",
> > > +		.owner = THIS_MODULE,
> > > +		.of_match_table = of_ltc2952_poweroff_match,
> > > +	},
> > > +	.suspend = ltc2952_poweroff_suspend,
> > > +	.resume = ltc2952_poweroff_resume,
> > 
> > I think you are supposed to put the suspend and resume calls into the driver
> > structure. The platform code names the callbacks here 'legacy'.
> 
> I'll check that out.

They are supposed to go into a pm_ops structure, which is pointed at in
driver's pm pointer. I'll drop them in any case. It would lead to a
bunch of boiler plate for nothing.

Frans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/