Re: [PATCH V3] Staging: rtl8712 removed unnecessary else after return

From: Greg KH
Date: Wed Oct 08 2014 - 18:44:20 EST


On Thu, Oct 02, 2014 at 02:32:26PM +0200, Nitin Kuppelur wrote:
> Removed unnecessary else after return to solve
> checkpatch.pl warning
>
> Signed-off-by: Nitin Kuppelur <nitinkuppelur@xxxxxxxxx>
> ---
> drivers/staging/rtl8712/hal_init.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c
> index 81cd654..fbaba11 100644
> --- a/drivers/staging/rtl8712/hal_init.c
> +++ b/drivers/staging/rtl8712/hal_init.c
> @@ -387,12 +387,9 @@ uint rtl8712_hal_deinit(struct _adapter *padapter)
> uint rtl871x_hal_init(struct _adapter *padapter)
> {
> padapter->hw_init_completed = false;
> - if (padapter->halpriv.hal_bus_init == NULL)
> + if (padapter->halpriv.hal_bus_init == NULL ||
> + padapter->halpriv.hal_bus_init(padapter) != _SUCCESS)
> return _FAIL;
> - else {
> - if (padapter->halpriv.hal_bus_init(padapter) != _SUCCESS)
> - return _FAIL;
> - }
> if (rtl8712_hal_init(padapter) == _SUCCESS)
> padapter->hw_init_completed = true;
> else {

This doesn't apply to my tree :(
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/