Re: [PATCH 1/1] ftruncate: create FAN_MODIFY and IN_MODIFY events

From: Jan Kara
Date: Mon Oct 06 2014 - 09:24:58 EST


On Fri 03-10-14 20:16:30, Heinrich Schuchardt wrote:
> The fanotify and the inotify API can be used to monitor changes of the file
> system.
>
> System call ftruncate modifies files. Hence it should trigger the corresponding
> fanotify (FAN_MODIFY) and inotify (IN_MODIFY) events.
Hum, I would think that the appropriate event gets generated by
fsnotify_change() called from notify_change()?

Honza
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@xxxxxx>
> ---
> fs/open.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/open.c b/fs/open.c
> index d6fd3ac..e36f26e 100644
> --- a/fs/open.c
> +++ b/fs/open.c
> @@ -189,6 +189,8 @@ static long do_sys_ftruncate(unsigned int fd, loff_t length, int small)
> error = security_path_truncate(&f.file->f_path);
> if (!error)
> error = do_truncate(dentry, length, ATTR_MTIME|ATTR_CTIME, f.file);
> + if (!error)
> + fsnotify_modify(f.file);
> sb_end_write(inode->i_sb);
> out_putf:
> fdput(f);
> --
> 2.1.0
>
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/