Re: [PATCH 3/4] [media] Remove optional dependency on PLAT_S5P

[Paul Bolle]

On Mon, 2014-10-06 at 11:26 +0200, Arnd Bergmann wrote:
> On Monday 06 October 2014 11:10:26 Paul Bolle wrote:
> >  config VIDEO_SAMSUNG_S5P_TV
> >         bool "Samsung TV driver for S5P platform"
> >         depends on PM_RUNTIME
> > -       depends on PLAT_S5P || ARCH_EXYNOS || COMPILE_TEST
> > +       depends on ARCH_EXYNOS || COMPILE_TEST
> >         default n
> >         ---help---
> >           Say Y here to enable selecting the TV output devices for
> > 
> 
> I wonder if it should now allow being built for ARCH_S5PV210.

That was what Tomasz Figa claimed in
http://lkml.kernel.org/r/53C676DB.6070002@xxxxxxxxxxx

> Maybe it was a mistake to remove the PLAT_S5P symbol without changing
> the use here?

At least it was a bit sloppy to remove the symbol without touching this
(and six other) dependencies. But after nearly three months I lost
patience waiting for a fix to be submitted.

My cleanup doesn't really change a thing. And a proper fix, if needed,
is still possible after this has landed.

> Does S5PV210 have this device?


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/