Re: [PATCH] mm: highmem remove 3 errors

From: Max Filippov
Date: Thu Oct 02 2014 - 11:54:53 EST


On Thu, Oct 2, 2014 at 7:44 PM, Paul McQuade <paulmcquad@xxxxxxxxx> wrote:
> pointers should be foo *bar or (foo *)
>
> Signed-off-by: Paul McQuade <paulmcquad@xxxxxxxxx>
> ---
> mm/highmem.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/highmem.c b/mm/highmem.c
> index 123bcd3..f6dae74 100644
> --- a/mm/highmem.c
> +++ b/mm/highmem.c
> @@ -130,7 +130,7 @@ unsigned int nr_free_highpages (void)
> static int pkmap_count[LAST_PKMAP];
> static __cacheline_aligned_in_smp DEFINE_SPINLOCK(kmap_lock);
>
> -pte_t * pkmap_page_table;
> +pte_t *pkmap_page_table;
>
> /*
> * Most architectures have no use for kmap_high_get(), so let's abstract
> @@ -291,7 +291,7 @@ void *kmap_high(struct page *page)
> pkmap_count[PKMAP_NR(vaddr)]++;
> BUG_ON(pkmap_count[PKMAP_NR(vaddr)] < 2);
> unlock_kmap();
> - return (void*) vaddr;
> + return (void *) vaddr;

checkpatch suggests that
CHECK: No space is necessary after a cast

> }
>
> EXPORT_SYMBOL(kmap_high);
> @@ -318,7 +318,7 @@ void *kmap_high_get(struct page *page)
> pkmap_count[PKMAP_NR(vaddr)]++;
> }
> unlock_kmap_any(flags);
> - return (void*) vaddr;
> + return (void *) vaddr;

Here as well.

--
Thanks.
-- Max
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/