RE: [PATCH 2/2] x86: Quark: Comment setup_arch for TLB/PGE bugfix

[Ong, Boon Leong]

> -----Original Message-----
> From: linux-kernel-owner@xxxxxxxxxxxxxxx [mailto:linux-kernel-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Bryan O'Donoghue
> Sent: Wednesday, October 01, 2014 7:42 AM
> To: tglx@xxxxxxxxxxxxx; mingo@xxxxxxxxxx; hpa@xxxxxxxxx;
> davej@xxxxxxxxxx; hmh@xxxxxxxxxx
> Cc: x86@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Bryan O'Donoghue
> Subject: [PATCH 2/2] x86: Quark: Comment setup_arch for TLB/PGE bugfix
> 
> Quark X1000 requires CR3 to be rewritten to flush TLB entries irrespective of
> the PGE bits in CR4 or PTE.PGE
> 
> Add a comment to setup_arch to indicate that the code
> 
> load_cr3(swapper_pg_dir);
> __flush_tlb_all();
> 
> Will already have flushed the TLB @ the CR3 reload allowing us to skip over a
> potential if/else for Quark.
> 
> This comment clearly states the bug, the behaviour we rely on and the reason
> why we only do it this way - one time.
> 
> Later on cpu_has_pge() will be false due to a fixup in
> intel_init_early() and __flush_tlb_all() will work as expected from that point
> onwards

s/intel_init_early/early_init_intel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/