Re: [PATCH 1/2] perf session: Add option to copy events when queueing

[David Ahern]

On 9/18/14, 2:21 PM, David Ahern wrote:
> On 9/18/14, 12:53 PM, Arnaldo Carvalho de Melo wrote:
> > If nobody objects I'll merge this patch, as it fixes problems, but I
> > wonder if the best wouldn't be simply not calling
> > perf_evlist__mmap_consume() till the last event there is in fact
> > consumed... I.e. as we _really_ consume the events, we remove it from
> > there.
> >
> > Instead of consuming the event at perf_tool->sample() time, we would
> > do it at perf_tool->finished_round(), would that be feasible? Has anyone
> > tried this?
>
> Hmmm... haven't tried this.  Conceptually it should work - at least
> nothing comes to mind at the moment.

Upon further review ...

Alex you might want to try this first. Malloc and copy of all events is 
going to bring some serious overhead. Can avoid that if consuming the 
event in finished_round works.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/