Re: [PATCH v3 02/12] btrfs: LLVMLinux: Remove VLAIS

From: Chris Mason
Date: Wed Sep 17 2014 - 09:50:21 EST




On 09/15/2014 03:30 AM, behanw@xxxxxxxxxxxxxxxxxx wrote:
> From: VinÃcius Tinti <viniciustinti@xxxxxxxxx>
>
> Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99
> compliant equivalent. This is the original VLAIS struct.
>
> struct {
> struct shash_desc shash;
> char ctx[crypto_shash_descsize(tfm)];
> } desc;
>
> This patch instead allocates the appropriate amount of memory using a
> char array using the SHASH_DESC_ON_STACK macro.
>
> The new code can be compiled with both gcc and clang.
>
> Signed-off-by: VinÃcius Tinti <viniciustinti@xxxxxxxxx>
> Reviewed-by: Jan-Simon MÃller <dl9pf@xxxxxx>
> Reviewed-by: Mark Charlebois <charlebm@xxxxxxxxx>
> Signed-off-by: Behan Webster <behanw@xxxxxxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Acked-by: Chris Mason <clm@xxxxxx>

On the btrfs bits. Thanks for the v3.

-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/