Re: [PATCH v3] ARM: apq8064: Add pinmux and i2c pinctrl nodes

From: kiran . padwal
Date: Tue Sep 16 2014 - 08:36:56 EST




On Monday, September 15, 2014 10:39pm, "Andy Gross" <agross@xxxxxxxxxxxxxx> said:

> On Tue, Aug 26, 2014 at 05:00:45PM +0530, Kiran Padwal wrote:
>> This patch adds pinmux and i2c pinctrl DT node for IFC6410 board.
>> It also adds necessary DT support for i2c eeprom which is present on
>> IFC6410.
>>
>> Tested on IFC6410 board.
>
> Looks fine

Thanks for review.

>
>>
>> Signed-off-by: Kiran Padwal <kiran.padwal@xxxxxxxxxxxxxxx>
>> ---
>> Changes since v2:
>> - Renamed pinmux i2c subnode "i2c1_pinmux" to "i2c1".
>> - Removed labes of node.
>> - Used canonical value as "okay" instead of "ok".
>> - Used macros.
>>
>> Changes since v1:
>> - Renamed pinmux phandle "qcom_pinmux" to "tlmm_pinmux".
>> - Updated pinmux interrupt.
>>
>> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 27 ++++++++++++++
>> arch/arm/boot/dts/qcom-apq8064.dtsi | 53 ++++++++++++++++++++++++++++
>> 2 files changed, 80 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> index 7c2441d..ef0857e 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts
>> @@ -5,6 +5,24 @@
>> compatible = "qcom,apq8064-ifc6410", "qcom,apq8064";
>>
>> soc {
>> + gsbi@12440000 {
>> + status = "okay";
>> + qcom,mode = <GSBI_PROT_I2C>;
>> +
>> + i2c@12460000 {
>> + status = "okay";
>> + clock-frequency = <200000>;
>> + pinctrl-0 = <&i2c1_pins>;
>> + pinctrl-names = "default";
>> +
>> + eeprom: eeprom@52 {
>> + compatible = "atmel,24c128";
>> + reg = <0x52>;
>> + pagesize = <32>;
>> + };
>
> don't need read only here. the eeprom is not being used by anything....
> thankfully.
>
>> + };
>> + };
>> +
>> gsbi@16600000 {
>> status = "ok";
>> qcom,mode = <GSBI_PROT_I2C_UART>;
>> @@ -12,5 +30,14 @@
>> status = "ok";
>> };
>> };
>> +
>> + pinmux@800000 {
>> + i2c1_pins: i2c1 {
>> + mux {
>> + pins = "gpio20", "gpio21";
>> + function = "gsbi1";
>> + };
>> + };
>> + };
>> };
>> };
>> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi
>> b/arch/arm/boot/dts/qcom-apq8064.dtsi
>> index 92bf793..5dddbf3 100644
>> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
>> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
>> @@ -89,6 +89,17 @@
>> cpu-offset = <0x80000>;
>> };
>>
>> + tlmm_pinmux: pinmux@800000 {
>> + compatible = "qcom,apq8064-pinctrl";
>> + reg = <0x800000 0x4000>;
>> +
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + interrupts = <0 16 IRQ_TYPE_LEVEL_HIGH>;
>> + };
>> +
>> acc0: clock-controller@2088000 {
>> compatible = "qcom,kpss-acc-v1";
>> reg = <0x02088000 0x1000>, <0x02008000 0x1000>;
>> @@ -133,6 +144,48 @@
>> regulator;
>> };
>>
>> + gsbi1: gsbi@12440000 {
>> + status = "disabled";
>> + compatible = "qcom,gsbi-v1.0.0";
>> + reg = <0x12440000 0x100>;
>> + clocks = <&gcc GSBI1_H_CLK>;
>> + clock-names = "iface";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges;
>> +
>> + i2c1: i2c@12460000 {
>> + compatible = "qcom,i2c-qup-v1.1.1";
>> + reg = <0x12460000 0x1000>;
>> + interrupts = <0 194 IRQ_TYPE_NONE>;
>> + clocks = <&gcc GSBI1_QUP_CLK>, <&gcc GSBI1_H_CLK>;
>> + clock-names = "core", "iface";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + };
>> + };
>> +
>> + gsbi2: gsbi@12480000 {
>> + status = "disabled";
>> + compatible = "qcom,gsbi-v1.0.0";
>> + reg = <0x12480000 0x100>;
>> + clocks = <&gcc GSBI2_H_CLK>;
>> + clock-names = "iface";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges;
>> +
>> + i2c2: i2c@124a0000 {
>> + compatible = "qcom,i2c-qup-v1.1.1";
>> + reg = <0x124a0000 0x1000>;
>> + interrupts = <0 196 IRQ_TYPE_NONE>;
>> + clocks = <&gcc GSBI2_QUP_CLK>, <&gcc GSBI2_H_CLK>;
>> + clock-names = "core", "iface";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + };
>> + };
>> +
>> gsbi7: gsbi@16600000 {
>> status = "disabled";
>> compatible = "qcom,gsbi-v1.0.0";
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/