Re: [PATCH v2 0/7] mtd: denali: A collection of trivial coding style fixes

From: Brian Norris
Date: Mon Sep 15 2014 - 20:36:47 EST


On Tue, Sep 09, 2014 at 11:01:50AM +0900, Masahiro Yamada wrote:
> Changes in v2:
> - Join quotes strings into a single line
>
> Masahiro Yamada (7):
> mtd: denali: fix the format of comment blocks
> mtd: denali: remove unnecessary variable initializations
> mtd: denali: remove unnecessary casts
> mtd: denali: change the type of iterators to int
> mtd: denali: remove a set-but-unused variable
> mtd: denali: remove unnecessary parentheses
> mtd: denali: fix indents and other trivial things
>
> drivers/mtd/nand/denali.c | 562 +++++++++++++++++++++++++---------------------
> 1 file changed, 303 insertions(+), 259 deletions(-)

Pushed patches 1 to 5 to l2-mtd.git. Thanks!

Patch 6 has a conflict with another fix already in l2-mtd.git. Can you
rebase and resend?

BTW, my automatic build tests show that there's at least one other
'unused' warning left, in case you want to tackle it too:

drivers/mtd/nand/denali.c: In function âdenali_read_page_rawâ:
drivers/mtd/nand/denali.c:1221:11: warning: variable âirq_statusâ set but not used [-Wunused-but-set-variable]
uint32_t irq_status;

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/