Re: [PATCH] mfd: intel_soc_pmic: Add CONFIG_PM_SLEEP check for suspend_fn/resume_fn

From: Lee Jones
Date: Mon Sep 15 2014 - 19:07:37 EST


On Fri, 12 Sep 2014, Jaewon Kim wrote:

> This patch fix warning message with CONFIG_PM_SLEEP disabled
> If CONFIG_PM_SLEEP is not enabled we receive the following warning message:
>
> drivers/mfd/intel_soc_pmic_core.c:118:12:
> warning: 'intel_soc_pmic_suspend' defined but not used
>
> Signed-off-by: Jaewon Kim <jaewon02.kim@xxxxxxxxxxx>
> ---
> drivers/mfd/intel_soc_pmic_core.c | 2 ++
> 1 file changed, 2 insertions(+)

Applied, thanks.

> diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c
> index 2720922..df7b064 100644
> --- a/drivers/mfd/intel_soc_pmic_core.c
> +++ b/drivers/mfd/intel_soc_pmic_core.c
> @@ -115,6 +115,7 @@ static void intel_soc_pmic_shutdown(struct i2c_client *i2c)
> return;
> }
>
> +#if defined(CONFIG_PM_SLEEP)
> static int intel_soc_pmic_suspend(struct device *dev)
> {
> struct intel_soc_pmic *pmic = dev_get_drvdata(dev);
> @@ -132,6 +133,7 @@ static int intel_soc_pmic_resume(struct device *dev)
>
> return 0;
> }
> +#endif
>
> static SIMPLE_DEV_PM_OPS(intel_soc_pmic_pm_ops, intel_soc_pmic_suspend,
> intel_soc_pmic_resume);

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/