RE: [PATCH 0/3] staging: comedi: adl_pci9118: redo DMA buffer allocation

[Hartley Sweeten]

On Friday, September 12, 2014 2:05 AM, Ian Abbott wrote:
> "adl_pci9118" allocates more pages of DMA buffer than it uses, may
> allocate half a double-buffer it does not use because it's the "wrong"
> half that it managed to allocate (unlikely), and relies on virt_to_bus()
> to treat generic kernel memory from get_free_pages() as coherent DMA
> memory.  Correct the issues, using dma_alloc_coherent() to allocate the
> DMA buffers.
>
> 1) staging: comedi: adl_pci9118: don't allocate 2nd DMA buffer on failure
> 2) staging: comedi: adl_pci9118: don't overallocate DMA buffer
> 3) staging: comedi: adl_pci9118: use dma_alloc_coherent()
>
>  drivers/staging/comedi/Kconfig               |  2 +-
>  drivers/staging/comedi/drivers/adl_pci9118.c | 40 ++++++++++++++--------------
>  2 files changed, 21 insertions(+), 21 deletions(-)

Thanks. Know I don't need to look into how to remove the
virt_to_bus()... ;-)

Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/