Re: [PATCH] spi: pl022: Add support for chip select extension

From: Anders Berg
Date: Mon Sep 15 2014 - 07:00:01 EST


On Fri, Sep 12, 2014 at 7:00 PM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Thu, Sep 11, 2014 at 10:10 PM, Anders Berg <anders.berg@xxxxxxxxxxxxx> wrote:
(...)
>> I picked 0xb6 since I've seen some reference manuals for other AMBA
>> peripherals the use of JEDEC assigned vendor IDs in this register field (see
>> the PL390 TRM for example). So I put the LSI Logic 7-bit JEDEC ID (0x36)
>> there: [0:6] = 0x36, [7] = 1 (the MSB set to '1' to signify the use of JEDEC
>> ID instead of a "classic" AMBA vendor).
>
> Hey that's very observant, I had no clue about that scheme!
>
> Can you write a comment about this in <linux/amba/bus.h> when
> you patch it (like above the enum) so we know that in the future
> when people need to pick new IDs?

Sure, will do.

/Anders
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/