Re: [PATCH] arch/microblaze/kernel/setup.c: Add default 'screen_info" for fixing compiling break

[Jesper Nilsson]

On Sun, Sep 14, 2014 at 10:45:23AM +0200, Geert Uytterhoeven wrote:
> Hi Chen,
> 
> On Sun, Sep 14, 2014 at 10:32 AM, Chen Gang <gang.chen.5i5j@xxxxxxxxx> wrote:
> > Add default one just like other architectures have done (e.g. cris,
> > score, sh ...), the related error with allmodconfig:
> >
> >     LD      init/built-in.o
> >   drivers/built-in.o: In function `vgacon_save_screen':
> >   drivers/video/console/.tmp_vgacon.o:(.text+0x834d0): undefined reference to `screen_info'
> >   drivers/video/console/.tmp_vgacon.o:(.text+0x834ec): undefined reference to `screen_info'
> >   drivers/built-in.o: In function `vgacon_resize':
> >   drivers/video/console/.tmp_vgacon.o:(.text+0x83cdc): undefined reference to `screen_info'
> >   drivers/video/console/.tmp_vgacon.o:(.text+0x83d38): undefined reference to `screen_info'
> >   drivers/built-in.o: In function `vgacon_switch':
> >   drivers/video/console/.tmp_vgacon.o:(.text+0x83f50): undefined reference to `screen_info'
> >   drivers/built-in.o:drivers/video/console/.tmp_vgacon.o:(.text+0x8407c): more undefined references to `screen_info' follow
> >   make: *** [vmlinux] Error 1
> 
> Can microblaze actually have VGA?
> 
> If not, it's better to disable it.
> 
> BTW, it's interesting you mention cris, as VGA_CONSOLE depends on !CRIS
> in drivers/video/console/Kconfig...

No CRIS platform has ever had a video console.

> I (still) think it's time to introduce ARCH_MIGHT_HAVE_VGA, and make
> VGA_CONSOLE depend on that, cfr.

Sounds reasonable, at least it can avoid the specific depends on !*arch* cruft.

> Gr{oetje,eeting}s,
> 
>                         Geert

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@xxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/