Re: [PATCH v3 5/5] iio: add documentation for current attribute

[Hartmut Knaack]

Jonathan Cameron schrieb, Am 13.09.2014 21:55:
> On 12/09/14 00:15, Jacob Pan wrote:
>> Add documentation for input current raw reading and scale.
>>
>> Signed-off-by: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>
> The content is fine, but please look at how the other types are handled.
> The raw attribute is described along with the units etc in it's own
> section, but the _scale attribute just gets lumped in with the equivalent
> for all the other channel types.
> 
> Thanks,
> 
> Jonathan
>> ---
>>  Documentation/ABI/testing/sysfs-bus-iio | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
>> index d760b02..3c76bd8 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-iio
>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
>> @@ -1028,3 +1028,11 @@ Contact:	linux-iio@xxxxxxxxxxxxxxx
>>  Description:
>>  		Raw value of rotation from true/magnetic north measured with
>>  		or without compensation from tilt sensors.
>> +
>> +What:		/sys/bus/iio/devices/iio:deviceX/in_currentX_raw
>> +What:		/sys/bus/iio/devices/iio:deviceX/in_currentX_scale
>> +KernelVersion:	3.18
>> +Contact:	linux-iio@xxxxxxxxxxxxxxx
>> +Description:
>> +		Raw current measurement from channel X. Units after application of
>> +		scale and offset are milliamps.
Where is the offset?
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/