Re: [PATCH] netdev: octeon_mgmt: ISO C90 forbids mixed declarations and code

From: David Miller
Date: Sat Sep 13 2014 - 16:03:12 EST


From: Joe Perches <joe@xxxxxxxxxxx>
Date: Sat, 13 Sep 2014 12:11:12 -0700

> On Sat, 2014-09-13 at 21:05 +0200, Heinrich Schuchardt wrote:
>> Compiling with OCTEON_MGMT_ETHERNET gives a warning
>> drivers/net/ethernet/octeon/octeon_mgmt.c:295:4:
>> warning: ISO C90 forbids mixed declarations and code
>> [-Wdeclaration-after-statement]
>
> Maybe better to move the memset after the declaration.

Totally agree, keep the variable in the innermost scope
in which it is used.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/