Re: [PATCH 2/4] usb: hub: remove obsolete while cycle in hub_event()

From: Alan Stern
Date: Fri Sep 12 2014 - 10:23:31 EST


On Fri, 12 Sep 2014, Petr Mladek wrote:

> The USB hub events are proceed by workqueue instead of kthread now.
> The result is that hub_event() function processes only one event.
> The while cycle was not removed earlier to show the real changes when
> switching to the workqueue.
>
> This patch also consolidates the goto targets and rename them from "loop*"
> to "out*".
>
> When touching the code, it fixes also formatting of dev_err() and dev_dbg()
> calls to make checkpatch.pl happy :-)

Although the reason given in the description above is not really
accurate, removing the loop in hub_events is a reasonable thing to do.
That loop doesn't serve any purpose as far as I can see.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/