Re: [PATCH 3/4] regulator/axp20x: use axp2xx consolidated header

From: Jacob Pan
Date: Thu Sep 11 2014 - 18:27:56 EST


On Tue, 9 Sep 2014 12:25:16 +0100
Mark Brown <broonie@xxxxxxxxxx> wrote:

> On Mon, Sep 08, 2014 at 03:24:05PM -0700, Jacob Pan wrote:
> > AXP20x driver has been extended to support axp288 variant. Header
> > file and common data structures has also been renamed to suit the
> > new scope of devices supported.
> >
> > This patch makes use of the renamed header and structure.
>
> > -#include <linux/mfd/axp20x.h>
> > +#include <linux/mfd/axp2xx.h>
>
> Acked-by: Mark Brown <broonie@xxxxxxxxxx>
>
> but is it really worth the effort of renaming everything? That's
> going to cause problems for things like the stable workflow.

sorry for the late reply. IMHO, consistent and correct naming has
longer term benefit. how can i help to make the stable workflow easier?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/