Re: [PATCH] tty: serial: men_z135_uart: Fix driver for changes in hardware

[Greg Kroah-Hartman]

On Wed, Sep 10, 2014 at 08:07:24AM +0200, Johannes Thumshirn wrote:
> On Tue, Sep 09, 2014 at 05:26:35PM -0700, Greg Kroah-Hartman wrote:
> > On Tue, Sep 09, 2014 at 07:56:15AM +0200, Johannes Thumshirn wrote:
> > > On Mon, Sep 08, 2014 at 04:17:33PM -0700, Greg Kroah-Hartman wrote:
> > > > >
> > > > > @@ -118,6 +117,10 @@ static int align;
> > > > >  module_param(align, int, S_IRUGO);
> > > > >  MODULE_PARM_DESC(align, "Keep hardware FIFO write pointer aligned, default 0");
> > > > >
> > > > > +static int rx_timeout;
> > > > > +module_param(rx_timeout, uint, S_IRUGO);
> > > > > +MODULE_PARM_DESC(rx_timeout, "RX timeout");
> > > >
> > > > Why add a module parameter?  Who will know to set this?  And to what
> > > > value?
> > > >
> > >
> > > There will be a user manual describing the parameter. It's like the rxlvl and
> > > txlvl parameters, you'll have to read the manual if you need other values than
> > > the default ones.
> >
> > Ugh, but module parameters are for all devices in the system of this
> > type, which is why we try not to have them at all anymore.
> >
> > And I don't like the other module parameters either :(
> >
> > But it's an odd-one-off driver, I guess we can live...
> 
> Just for my information, what would be the correct way to do these kinds of
> hardware specific settings? Sysfs? Debugfs? Custom ioctl()s (no struct file_operations,
> so probably not)?

For serial ports, odds are there is already some other way to do this
through a common interface...

But sysfs is a good way to go if you really need it, just document it
properly in Documentation/ABI/

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/