Re: [PATCH v2 2/4] mfd/axp2xx: extend axp20x to support axp288 pmic

From: Maxime Ripard
Date: Wed Sep 10 2014 - 04:30:15 EST


On Tue, Sep 09, 2014 at 06:02:53AM -0700, Jacob Pan wrote:
> XPower AXP288 is a customized PMIC for Intel Baytrail-CR platforms. Similar
> to AXP202/209, AXP288 comes with USB charger, more LDO and BUCK channels, and
> AD converter. It also provides extended status and interrupt reporting
> capabilities than the devices supported in axp20x.c.
>
> In addition to feature extension, this patch also adds ACPI binding for
> enumeration and hooks for ACPI custom operational region handlers.
>
> Files and common data structures have been renamed from axp20x to axp2xx
> in order to suit the extended scope of devices.

I still feel like this renaming should be in the first patch that is
already advertised at doing it.

This is quite hard to tell what you are actually doing in this patch,
besides the renaming that is.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Attachment: signature.asc
Description: Digital signature