Re: [PATCH v8 1/3] usb: gadget: f_fs: fix the redundant ep files problem

[Felipe Balbi]

On Tue, Sep 09, 2014 at 10:04:26AM -0500, Felipe Balbi wrote:
> On Tue, Sep 09, 2014 at 08:23:15AM +0200, Robert Baldyga wrote:
> > Up to now, when endpoint addresses in descriptors were non-consecutive,
> > there were created redundant files, which could cause problems in kernel,
> > when user tried to read/write to them. It was result of fact that maximum
> > endpoint address was taken as total number of endpoints in funciton.
> > 
> > This patch adds endpoint descriptors counting and storing their addresses
> > in eps_addrmap to verify their cohesion in each speed.
> > 
> > Endpoint address map would be also useful for further features, just like
> > vitual endpoint address mapping.
> > 
> > Signed-off-by: Robert Baldyga <r.baldyga@xxxxxxxxxxx>
> > Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>
> 
> This is a fix, which sits in my 'fixes' branch. You can't include it
> here. This series should be rebased on top of my 'next' but it should
> not include any fixes, only new code.
> 
> This is why we generally ask people to split the series up into fixes
> and new code and not make them depend on each other. You need to
> remember that, rather frequently, my 'next' branch is based off of -rc1.
> 
> I only merge an -rc back into my 'next' when the conflicts start to
> become non-trivial because of all the dependencies people add :-)
> 
> I'll see if I can fix this up myself, but if I can't, then we either
> postpone this series to v3.19 or you get it done properly and without
> any cross-dependencies :-)

alright, so patch 2 I can apply. Patch 3 I really cannot because it
depends on epaddr_map to create proper files on the filesystem.

I'll see if I can wait for -rc5 before merging patch 3, but it's likely
it'll slip into v3.19.

-- 
balbi

Attachment: signature.asc
Description: Digital signature