Re: [PATCH v8] usb:serial:pl2303: add GPIOs interface on PL2303

From: Johan Hovold
Date: Tue Sep 09 2014 - 10:04:13 EST


On Tue, Sep 09, 2014 at 12:43:56PM +0200, Johan Hovold wrote:
> On Tue, Sep 09, 2014 at 06:21:31PM +0800, Wang YanQing wrote:
> > On Tue, Sep 09, 2014 at 12:08:56PM +0200, Johan Hovold wrote:
> > > On Fri, Sep 05, 2014 at 09:30:11AM +0800, Wang YanQing wrote:
> > > > On Thu, Sep 04, 2014 at 06:44:31PM +0200, Benjamin Henrion wrote:
> > > > > On Thu, Sep 4, 2014 at 6:14 PM, Benjamin Henrion <zoobab@xxxxxxxxx> wrote:
> > > > > > I have subscribed to the lkml.
> > > > > >
> > > > > > Can you make me a favour, send me your email as you posted on the LKML
> > > > > > in mbox format attached to an email?
> > > > > >
> > > > > > I am trying to reply to it, but I cannot find an mbox archive, outside
> > > > > > of gmane which rewrites all the email addresses.
> > > > > >
> > > > > > Otherwise, I made a page here:
> > > > > >
> > > > > > http://www.zoobab.com/pl2303hxd-gpio
> > > > > >
> > > > > > I will also try with other adapters to see if the 2 GPIOs show up.
> > > > > >
> > > > > > Any idea how to test the GPIO sysfs speed?
> > > > >
> > > > > Also tested with an HXA laying around, I could export the 2 GPIOS in
> > > > > /sys/class/gpio, but I could not change the status of the pins via
> > > > > echo.
> > > > >
> > > > > Any idea why?
> > > >
> > > > It is strange, I have tested again with my two HXA adapters, they work well.
> > > > How do you test? check cat value or check voltage change? I check cat value,
> > > > and they work good.
> > >
> > > So you haven't verified that the voltage actually changes?
> > >
> > > Johan
> >
> > I have verified the voltage actually changes in previous patch version,
> > but I haven't verified that with v8.
>
> Ok, good. I'll get back to you with some comments on v8 shortly.

Wait a minute. You restructured the driver, added support for two new
gpios as well as another device type, so you need to verify the voltage
on the pins (on both device types) as well.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/