RE: [PATCH v2] QE: move qe code from arch/powerpc to drivers/soc

[qiang.zhao@xxxxxxxxxxxxx]

On Fri, 2014-09-05 at 06:47 AM, Wood Scott wrote:



> Subject: Re: [PATCH v2] QE: move qe code from arch/powerpc to drivers/soc
> 
> On Thu, 2014-09-04 at 13:06 +0800, Zhao Qiang wrote:
> > LS1 is arm cpu and it has qe ip block.
> > move qe code from platform directory to public directory.
> >
> > QE is an IP block integrates several comunications peripheral
> > controllers. It can implement a variety of applications, such as uart,
> > usb and tdm and so on.
> >
> > Signed-off-by: Zhao Qiang <B45475@xxxxxxxxxxxxx>
> > ---
> > Changes for v2:
> > 	- mv code to drivers/soc
> 
> Who will be the maintainer of this code once it lives in drivers/soc,
> especially once it is no longer used only by PPC?

I have no idea about that, can you explain why you want to know who will be the maintainer.

> 
> >  44 files changed, 113 insertions(+), 113 deletions(-)  delete mode
> > 100644 arch/powerpc/sysdev/qe_lib/Kconfig
> >  create mode 100644 drivers/soc/qe/Kconfig  rename
> > {arch/powerpc/sysdev/qe_lib => drivers/soc/qe}/Makefile (100%)  rename
> > {arch/powerpc/sysdev/qe_lib => drivers/soc/qe}/gpio.c (99%)  rename
> > {arch/powerpc/sysdev/qe_lib => drivers/soc/qe}/qe.c (99%)  rename
> > {arch/powerpc/sysdev/qe_lib => drivers/soc/qe}/qe_ic.c (99%)  rename
> > {arch/powerpc/sysdev/qe_lib => drivers/soc/qe}/qe_ic.h (98%)  rename
> > {arch/powerpc/sysdev/qe_lib => drivers/soc/qe}/qe_io.c (99%)  rename
> > {arch/powerpc/sysdev/qe_lib => drivers/soc/qe}/ucc.c (98%)  rename
> > {arch/powerpc/sysdev/qe_lib => drivers/soc/qe}/ucc_fast.c (98%)
> > rename {arch/powerpc/sysdev/qe_lib => drivers/soc/qe}/ucc_slow.c (98%)
> > rename {arch/powerpc/sysdev/qe_lib => drivers/soc/qe}/usb.c (96%)
> 
> drivers/soc/fsl-qe
> 
> > diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile index
> > 0f7c447..5da1a482 100644
> > --- a/drivers/soc/Makefile
> > +++ b/drivers/soc/Makefile
> > @@ -3,3 +3,5 @@
> >  #
> >
> >  obj-$(CONFIG_ARCH_QCOM)		+= qcom/
> > +
> > +obj-$(CONFIG_QUICC_ENGINE)     += qe/
> 
> Please keep the file consistent regarding tabs versus spaces.
> 
> Plus, why do you need a newline between them?

I will modify it in v3

> 
> > diff --git a/drivers/soc/qe/Kconfig b/drivers/soc/qe/Kconfig new file
> > mode 100644 index 0000000..8b03ca2
> > --- /dev/null
> > +++ b/drivers/soc/qe/Kconfig
> > @@ -0,0 +1,45 @@
> > +#
> > +# QE Communication options
> > +#
> > +config QUICC_ENGINE
> > +	bool "Freescale QUICC Engine (QE) Support"
> > +	depends on FSL_SOC && PPC32
> > +	select PPC_LIB_RHEAP
> > +	select CRC32
> > +	help
> > +	  The QUICC Engine (QE) is a new generation of communications
> > +	  coprocessors on Freescale embedded CPUs (akin to CPM in older
> chips).
> > +	  Selecting this option means that you wish to build a kernel
> > +	  for a machine with a QE coprocessor.
> > +
> > +config QE_GPIO
> > +	bool "QE GPIO support"
> > +	depends on QUICC_ENGINE
> > +	select ARCH_REQUIRE_GPIOLIB
> > +	help
> > +	  Say Y here if you're going to use hardware that connects to the
> > +	  QE GPIOs.
> > +
> > +config UCC_SLOW
> > +	bool
> > +	default y if SERIAL_QE
> > +	help
> > +	  This option provides qe_lib support to UCC slow
> > +	  protocols: UART, BISYNC, QMC
> > +
> > +config UCC_FAST
> > +	bool
> > +	default y if UCC_GETH
> > +	help
> > +	  This option provides qe_lib support to UCC fast
> > +	  protocols: HDLC, Ethernet, ATM, transparent
> > +
> > +config UCC
> > +	bool
> > +	default y if UCC_FAST || UCC_SLOW
> > +
> > +config QE_USB
> > +	bool
> > +	default y if USB_FSL_QE
> > +	help
> > +	  QE USB Controller support
> 
> First could we give these names better namespacing?

Add FSL as prefix?

> 
> -Scott
> 
Regards,
Zhao Qiang