Re: [PATCH] x86_64: Add memcpy32_toio to write to PCI MMIO

[Clemens Ladisch]

Subhransu S. Prusty wrote:
> This is needed because the hardware

Which hardware?  Every x86-64 CPU ever built by AMD, Intel, and VIA?

> does not support 64-bit moveq insructions while writing to PCI MMIO.

> +#ifndef CONFIG_X86_64
> +#define MEMCPY_TOIO memcpy_toio
> +#else
> +#define MEMCPY_TOIO memcpy32_toio
> +#endif

This does not change any code that uses memcpy_toio().

> +	for (i = 0; i < count/sizeof(u32); i++)
> +		writel(*src_32++, dst_32++);

This breaks when count is not a multiple of four.


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/