Re: [PATCH 4/5] x86, mm: Add set_memory_wt() for WT

From: Toshi Kani
Date: Mon Sep 08 2014 - 11:18:20 EST


On Sun, 2014-09-07 at 09:49 -0700, Andy Lutomirski wrote:
> On Sun, Sep 7, 2014 at 1:49 AM, Yigal Korman <yigal@xxxxxxxxxxxxx> wrote:
> > I think that what confused Andy (or at least me) is the documentation in Documentation/x86/pat.txt
> > If it's possible, can you please update pat.txt as part of the patch?
>
> Indeed. That file seems to indicate several times that the intended
> use of set_memory_xyz is for RAM.


Good point. pat.txt is correct that the "intended" use of
set_memory_xyz() is for RAM since there is no other way to set non-WB
attribute for RAM. For reserved memory, one should call ioremap_xyz()
to map with the xyz attribute directly. From the functionality POV,
set_memory_xyz() works for reserved memory, but such usage is not
intended.

Should I drop the patch 4/5 until we can track the use of WT for RAM?

Thanks,
-Toshi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/