Re: [PATCH 5/6] scsi-lib: implement init_flush_rq and its pair

From: Christoph Hellwig
Date: Sun Sep 07 2014 - 14:53:43 EST

Next message: Pavel Machek: "Re: [PATCH 0/3] Yet another stab at a fpga framework"
Previous message: Christoph Hellwig: "Re: [PATCH 4/6] virtio-blk: implement init_flush_rq"
In reply to: Ming Lei: "[PATCH 5/6] scsi-lib: implement init_flush_rq and its pair"
Next in thread: Ming Lei: "[PATCH 2/6] blk-mq: introduce init_flush_rq callback and its pair"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> +static int __scsi_init_request(struct request *rq, int numa_node)

Nitpick: Please use a sane name here, e.g. scsi_mq_alloc/free_sense_buffer.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Pavel Machek: "Re: [PATCH 0/3] Yet another stab at a fpga framework"
Previous message: Christoph Hellwig: "Re: [PATCH 4/6] virtio-blk: implement init_flush_rq"
In reply to: Ming Lei: "[PATCH 5/6] scsi-lib: implement init_flush_rq and its pair"
Next in thread: Ming Lei: "[PATCH 2/6] blk-mq: introduce init_flush_rq callback and its pair"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]