Re: [PATCH v2 15/17] locks: give lm_break a return value

From: Christoph Hellwig
Date: Thu Sep 04 2014 - 14:08:23 EST


On Thu, Sep 04, 2014 at 08:38:41AM -0400, Jeff Layton wrote:
> Christoph suggests:
>
> "Add a return value to lm_break so that the lock manager can tell the
> core code "you can delete this lease right now". That gets rid of
> the games with the timeout which require all kinds of race avoidance
> code in the users."
>
> Do that here and have the nfsd lease break routine use it when it detects
> that there was a race between setting up the lease and it being broken.

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/