Re: [PATCH] ARM: cns3xxx: fix allmodconfig panic in pci driver

[Arnd Bergmann]

On Wednesday 03 September 2014 21:18:12 Xia Kaixu wrote:
> From: Xia Kaixu <kaixu.xia@xxxxxxxxxx>
> 
> The kernel panic occurs when running an allmodconfig kernel on 
> OMAP4460. The inicall "cns3xxx_pcie_init" does not check which
> hardware it's running on and just tries to access to its specific 
> registers. Now call it from .init_late callback from the two
> machine descriptors.
> 
> Signed-off-by: Xia Kaixu <kaixu.xia@xxxxxxxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Anton Vorontsov <anton@xxxxxxxxxx>
> Cc: Felix Fietkau <nbd@xxxxxxxxxxx>
> Cc: Imre Kaloz <kaloz@xxxxxxxxxxx>
> Cc: linaro-kernel@xxxxxxxxxxxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx

Hi Kaixu,

it seems this time all the Cc's worked. One thing I just noticed is that
you confused the 'Signed-off-by' lines. I did look at the patch earlier
before you sent it out but unfortunately missed that.

You can read again in Documentation/SubmittingPatches about how
they work, but the short version is that you must never put someone
else's name in Signed-off-by under a patch you write yourself.
When we apply the patch, I (or whoever else does) will put that
line below yours to document who handled the patch.

Otherwise, the patch looks good to me, thanks a lot for doing it.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/