Re: [PATCH] init/Kconfig: Add ENDIAN attributes for all architectures using

[Paul Gortmaker]

[[PATCH] init/Kconfig: Add ENDIAN attributes for all architectures using] On 01/09/2014 (Mon 23:46) Chen Gang wrote:

> Some individual modules want to know the architecture's endian attribute
> during config time, or may cause compiling break, one sample is below:
> (with allm dconfig under microblaze):
> 
>     CC [M]  drivers/isdn/hisax/nj_s.o
>   drivers/isdn/hisax/nj_s.c: In function 'setup_netjet_s':
>   drivers/isdn/hisax/nj_s.c:265:2: error: #error "not running on big endian machines now"
>    #error "not running on big endian machines now"
> 
> So add endian attributes for all architectures using (next, will let all
> architectures choose their endians during config time).
> 
> Signed-off-by: Chen Gang <gang.chen.5i5j@xxxxxxxxx>
> ---
>  init/Kconfig | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index ac033c3..f301cc8 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -23,6 +23,12 @@ config CONSTRUCTORS
>  config IRQ_WORK
>  	bool
>  
> +config CPU_LITTLE_ENDIAN
> +	bool
> +
> +config CPU_BIG_ENDIAN
> +	bool

Perhaps you should take a cursory look at what already exists in tree
before blindly trying to add more to it?

$ git grep CPU_BIG_ENDIAN | wc -l
88

Paul.
--

> +
>  config BUILDTIME_EXTABLE_SORT
>  	bool
>  
> -- 
> 1.7.11.7
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/