Re: [RFC PATCH] powerpc: Wire up three syscalls

[David Herrmann]

Hi

On Mon, Sep 1, 2014 at 5:21 PM, Pranith Kumar <bobby.prani@xxxxxxxxx> wrote:
> Hi David,
>
> On Mon, Sep 1, 2014 at 7:33 AM, David Herrmann <dh.herrmann@xxxxxxxxx> wrote:
>>
>> Nice catch. We changed 'flags' from u64 to "unsigned int" in the last
>> revision of the series. Patch looks good, but I'd prefer using
>> "unsigned int" as type, instead of __u32. Just to be consistent with
>> the syscall interface. The return type of F_GET_SEALS is actually
>> "int" and the MSB is reserved for signed error codes, so you can
>> savely use "int r = fcntl(fd, F_GET_SEALS, 0)" in
>> mfd_assert_get_seals().
>>
>
> OK. Should I send a new patch with these changes or do you have one
> line up already?

I'd appreciate if you can resend it.

Btw., the original patch (wire up syscalls) can be applied unchanged.

Thanks
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/