Re: [PATCH v7] ARM: dts: Prepare node labels for exynos5250

[Doug Anderson]

Kukjin,

On Fri, Aug 22, 2014 at 3:49 AM, Kukjin Kim <kgene.kim@xxxxxxxxxxx> wrote:
> Andreas FÃrber wrote:
>>
>> Allows them to be extended by reference.
>>
>> Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx>
>> Signed-off-by: Andreas FÃrber <afaerber@xxxxxxx>
>> ---
>>  v6 -> v7:
>>  * Dropped uart* labels (Tomasz Figa)
>>
>>  v6: Split off from Snow/SMDK cleanups (Doug Anderson)
>>
>>  arch/arm/boot/dts/exynos5250.dtsi | 16 ++++++++--------
>>  1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
>> index 492e1eff37bd..42eafd19cfb2 100644
>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>> @@ -218,7 +218,7 @@
>>               clock-names = "fimg2d";
>>       };
>>
>> -     codec@11000000 {
>> +     mfc: codec@11000000 {
>>               compatible = "samsung,mfc-v6";
>>               reg = <0x11000000 0x10000>;
>>               interrupts = <0 96 0>;
>> @@ -227,7 +227,7 @@
>>               clock-names = "mfc";
>>       };
>>
>> -     rtc@101E0000 {
>> +     rtc: rtc@101E0000 {
>>               clocks = <&clock CLK_RTC>;
>>               clock-names = "rtc";
>>               status = "disabled";
>> @@ -261,7 +261,7 @@
>>               clock-names = "uart", "clk_uart_baud0";
>>       };
>>
>> -     sata@122F0000 {
>> +     sata: sata@122F0000 {
>>               compatible = "snps,dwc-ahci";
>>               samsung,sata-freq = <66>;
>>               reg = <0x122F0000 0x1ff>;
>> @@ -573,7 +573,7 @@
>>               #phy-cells = <1>;
>>       };
>>
>> -     usb@12110000 {
>> +     ehci: usb@12110000 {
>
> I'm not sure which one is recommended between above and "ehci: ehci@12110000 {"

My understanding is that more generic names should be used for node
names.  AKA: "usb" and not "ehci".  "mmc" and not "dwmmc".

In another thread I was pointed at ePAPR
<http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf>:

The name of a node should be somewhat generic, reflecting the function
of the device and not its precise programming model.


>> -     hdmi {
>> +     hdmi: hdmi {
>
> Should be
>
> +       hdmi: hdmi@14530000 { ?

Seems like that should be a followon patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/