Re: [PATCH 1/2] doc: dt/bindings: input: introduce TI DRV2667 haptic driver description

[Murphy, Dan]

Sergei
Thanks for the additional comments

On 08/21/2014 02:04 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 08/21/2014 10:19 PM, Dan Murphy wrote:
> 
>> DRV2667 is a haptic/vibrator driver for Linear Resonant Actuators.
>> Adding dt binding for this part
> 
>> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
>> ---
>>   .../devicetree/bindings/input/ti,drv2667.txt       |   18 ++++++++++++++++++
>>   1 file changed, 18 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/input/ti,drv2667.txt
> 
>> diff --git a/Documentation/devicetree/bindings/input/ti,drv2667.txt b/Documentation/devicetree/bindings/input/ti,drv2667.txt
>> new file mode 100644
>> index 0000000..525216d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/input/ti,drv2667.txt
>> @@ -0,0 +1,18 @@
>> +Texas Instruments - drv2667 Haptics driver
>> +
>> +The drv2667 uses serial control bus communicates through I2C protocols
>> +
>> +Required properties:
>> +	- compatible - "ti,drv2667" - DRV2667
>> +	- reg -  I2C slave address
>> +	- vbat-supply - Required supply regulator
>> +
>> +Example:
>> +
>> +drv2667: drv2667@59 {
> 
>     The ePAPR standard [1] has something to say on this matter:

What is this reference?  Did not know this existed so wanted to read up on it.

I can change it to haptics or vibrator

> 
> "The name of a node should be somewhat generic, reflecting the function of the 
> device and not its precise programming model."
> 
>> +		compatible = "ti,drv2667";
> 
>     Indented too much to the right.

One tab to many.  Got it

> 
>> +		reg = <0x59>;
> 
>     Still no "vbat-supply"... :-/
> 

Still have not sent in v2 of the patch yet.  Waiting on other comments.

>> +};
> [...]
> 
> WBR, Sergei
> 
> 


-- 
------------------
Dan Murphy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/