Re: [PATCH v3 12/13] pmcraid: Get rid of a redundant assignment

From: Tomas Henzl
Date: Thu Aug 21 2014 - 07:36:57 EST


On 08/18/2014 08:01 AM, Alexander Gordeev wrote:
> Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxx>
> Cc: Anil Ravindranath <anil_ravindranath@xxxxxxxxxxxxxx>
> Cc: linux-scsi@xxxxxxxxxxxxxxx
> Cc: linux-pci@xxxxxxxxxxxxxxx
> ---
> drivers/scsi/pmcraid.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> index 6f3275d..6e575ed 100644
> --- a/drivers/scsi/pmcraid.c
> +++ b/drivers/scsi/pmcraid.c
> @@ -4746,7 +4746,6 @@ pmcraid_isr_legacy:
> pinstance->hrrq_vector[0].drv_inst = pinstance;
> pinstance->hrrq_vector[0].vector = pdev->irq;
> pinstance->num_hrrq = 1;
> - rc = 0;
>
> rc = request_irq(pdev->irq, pmcraid_isr, IRQF_SHARED,
> PMCRAID_DRIVER_NAME, &pinstance->hrrq_vector[0]);

Patch looks good to me.

Reviewed-by: Tomas Henzl <thenzl@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/