Re: [PATCH 3/5] usb: phy: samsung: remove old USB 2.0 PHY driver

[Vivek Gautam]

Hi Tomasz and Bartlomiej,


On Mon, Aug 18, 2014 at 4:52 PM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote:
> On 18.08.2014 13:02, Bartlomiej Zolnierkiewicz wrote:
>> On Thursday, August 14, 2014 08:07:40 PM Vivek Gautam wrote:
>>> On Thursday, August 14, 2014 7:55 PM, Bartlomiej Zolnierkiewicz
>>> <b.zolnierkie@xxxxxxxxxxx> wrote
>>
>>> There's one thing that I would want to comment here, since we don't have any
>>> new usb-phy driver for S3C64XX,
>>> so we can't simply remove this entire driver.
>>> I have posted my patch-series [1], which does cleanup while keeping the
>>> support for S3C64XX.
>>
>> AFAIK S3C64XX code from drivers/usb/phy/phy-samsung-usb2.c has
>> never been used as this platform still uses its own code from
>> arch/arm/mach-s3c64xx/setup-usb-phy.c (there are no users in
>> the kernel tree of either s3c64xx-usb2phy platform device or
>> "samsung,s3c64xx-usb2phy" DT compatible) .  Therefore I think
>> that the entire drivers/usb/phy/phy-samsung-usb2.c driver
>> should be removed (somebody with the hardware can as well add
>> S3C64XX support to the new drivers/phy/phy-samsung-usb2.c
>> driver and port the platform to use it).
>>
>
> I agree with removal of this driver. As Bart said, it is not used for
> S3C64xx at all. The platform was supposed to be moved to this driver,
> but that never happened. In fact, I already have a patch adding support
> for S3C64xx to the new driver.

Cool then, lets remove this driver completely and use the new generic
PHY based driver
once that comes (from Tomasz).

I shall drop the patches for cleaning up the usb-phy drivers from my series.


-- 
Best Regards
Vivek Gautam
Samsung R&D Institute, Bangalore
India
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/